kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] bbejeck commented on a change in pull request #9486: KAFKA-9381: Fix publishing valid scaladoc for streams-scala
Date Mon, 26 Oct 2020 17:34:47 GMT

bbejeck commented on a change in pull request #9486:
URL: https://github.com/apache/kafka/pull/9486#discussion_r512145762



##########
File path: build.gradle
##########
@@ -731,6 +728,9 @@ project(':core') {
   println "Building project 'core' with Scala version ${versions.scala}"
 
   apply plugin: 'scala'
+  scaladoc {
+      enabled = false
+  }

Review comment:
       >Do we still need this with your latest change?
   
   I thought about taking it out, but I left it in as a fail-safe, thinking that if the build
file changes somehow enabling scaladoc for all submodules, `core` will only provide the scaladoc
jar file with the license and manifest.
   
   I don't have a strong opinion on this, so I can remove if you want me to.
   
   Ack on the indenting




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message