From jira-return-11778-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Apr 13 06:53:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E258A180627 for ; Fri, 13 Apr 2018 06:53:04 +0200 (CEST) Received: (qmail 19658 invoked by uid 500); 13 Apr 2018 04:53:04 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 19647 invoked by uid 99); 13 Apr 2018 04:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Apr 2018 04:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 55455C044F for ; Fri, 13 Apr 2018 04:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id n_oHnzz7r2pH for ; Fri, 13 Apr 2018 04:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C6CD75F126 for ; Fri, 13 Apr 2018 04:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C88D4E0C50 for ; Fri, 13 Apr 2018 04:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 162CF241C4 for ; Fri, 13 Apr 2018 04:53:00 +0000 (UTC) Date: Fri, 13 Apr 2018 04:53:00 +0000 (UTC) From: "Qiang Zhao (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (KAFKA-6787) enumerate SampledStat.samples got null item MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-6787?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1643= 6802#comment-16436802 ]=20 Qiang Zhao edited comment on KAFKA-6787 at 4/13/18 4:52 AM: ------------------------------------------------------------ It's critical and hard to fix. Hope someone else can take it. :D was (Author: koqizhao): It's critical and hard to fix. Home someone else can take it. :D > enumerate SampledStat.samples got null item > ------------------------------------------- > > Key: KAFKA-6787 > URL: https://issues.apache.org/jira/browse/KAFKA-6787 > Project: Kafka > Issue Type: Bug > Components: metrics > Affects Versions: 1.1.0 > Reporter: Qiang Zhao > Priority: Critical > Original Estimate: 168h > Remaining Estimate: 168h > > java.lang.NullPointerException at org.apache.kafka.common.metrics.stats.S= ampledStat.purgeObsoleteSamples(SampledStat.java:104) at org.apache.kafka.c= ommon.metrics.stats.SampledStat.measure(SampledStat.java:74) at org.apache.= kafka.common.metrics.KafkaMetric.metricValue(KafkaMetric.java:68) at kafka.= api.QuotaTestClients$.metricValue(BaseQuotaTest.scala:163) at kafka.api.Quo= taTestClients.produceUntilThrottled(BaseQuotaTest.scala:193) at kafka.api.B= aseQuotaTest.testThrottledProducerConsumer(BaseQuotaTest.scala:84) > =C2=A0 > {code:java} > protected void purgeObsoleteSamples(MetricConfig config, long now) { > long expireAge =3D config.samples() * config.timeWindowMs(); > for (Sample sample : samples) { > if (now - sample.lastWindowMs >=3D expireAge) // line 104, s= ample is null, probably is a concurrent issue > sample.reset(now); > } > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)