kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Badai Aqrandista (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-6756) client.id and group.id validation in the old vs new consumer
Date Fri, 06 Apr 2018 04:16:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Badai Aqrandista updated KAFKA-6756:
------------------------------------
    Description: 
It looks like the old consumer that is based on the Scala code validates "client.id" and "group.id"
using this code:

[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/common/Config.scala#L25]

[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/consumer/ConsumerConfig.scala#L60]

 

However, the new consumer uses the Java code does not validate "client.id" and "group.id"
at all here:

[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L264]

[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L298]

 

So the new consumer does not validate "client.id" and "group.id" like the old consumer. Either
way, the documentation never specify the valid character for "client.id" and "group.id".

Is this a bug or by design?

  was:
It looks like the old consumer that is based on the Scala code validates "client.id" and "group.id"
using this code:

[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/common/Config.scala#L25]

[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/consumer/ConsumerConfig.scala#L60]

 

However, the new consumer uses the Java code that does not validate "client.id" and "group.id"
at all here:

[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L264]

[https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L298]

So the new consumer does not validate "client.id" and "group.id" like the old consumer. Either
way, the documentation never specify the valid character for "client.id" and "group.id".

Is this a bug or by design?


> client.id and group.id validation in the old vs new consumer
> ------------------------------------------------------------
>
>                 Key: KAFKA-6756
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6756
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 0.10.2.1, 1.1.0
>            Reporter: Badai Aqrandista
>            Priority: Minor
>
> It looks like the old consumer that is based on the Scala code validates "client.id"
and "group.id" using this code:
> [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/common/Config.scala#L25]
> [https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/consumer/ConsumerConfig.scala#L60]
>  
> However, the new consumer uses the Java code does not validate "client.id" and "group.id"
at all here:
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L264]
> [https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java#L298]
>  
> So the new consumer does not validate "client.id" and "group.id" like the old consumer.
Either way, the documentation never specify the valid character for "client.id" and "group.id".
> Is this a bug or by design?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message