kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Randall Hauch (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (KAFKA-6740) Plugins class' newConverter and newHeaderConverter methods are unclear
Date Tue, 03 Apr 2018 13:42:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Randall Hauch reassigned KAFKA-6740:
------------------------------------

    Assignee: Randall Hauch

> Plugins class' newConverter and newHeaderConverter methods are unclear
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-6740
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6740
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 1.1.0
>            Reporter: Randall Hauch
>            Assignee: Randall Hauch
>            Priority: Major
>
> The ClassLoaderUsage enum is a bit unclear as to what the code is doing. The `CURRENT_CLASSLOADER`
is really about using the connector's configuration, whereas the `PLUGINS` literal is more
about using the worker's configuration. We should clean this up, and we should also look at
moving the if-block into the `CURRENT_CLASSLOADER` case in {{newConverter}}, just as we did
in the {{newHeaderConverter}} method in KAFKA-6728.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message