kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (KAFKA-6731) waitOnState waits for the wrong state instead of the target one
Date Mon, 02 Apr 2018 16:23:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-6731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthias J. Sax reassigned KAFKA-6731:
--------------------------------------

    Assignee: Matthias J. Sax  (was: huxihx)

> waitOnState waits for the wrong state instead of the target one
> ---------------------------------------------------------------
>
>                 Key: KAFKA-6731
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6731
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: huxihx
>            Assignee: Matthias J. Sax
>            Priority: Major
>             Fix For: 1.2.0
>
>
> In KafkaStreams.waitOnState, the code waits the state to be set to NOT_RUNNING instead
of the given target state. Is it deliberately as designed?
> {code:java}
> // ......
> while (state != State.NOT_RUNNING) {
>     if (waitMs == 0) {
>         try {
>             stateLock.wait();
>         } catch (final InterruptedException e) {
>             // it is ok: just move on to the next iteration
>         }
>     } else if (waitMs > elapsedMs) {
>         long remainingMs = waitMs - elapsedMs;
>         try {
>             stateLock.wait(remainingMs);
>         } catch (final InterruptedException e) {
>             // it is ok: just move on to the next iteration
>         }
>     } else {
>         log.debug("Cannot transit to {} within {}ms", targetState, waitMs);
>         return false;
>     }
>     elapsedMs = time.milliseconds() - begin;
> }
> return true;
> {code}
> IMO, it should check the state to be the target one. 
> [~guozhang] Does is make sense?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message