kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KAFKA-6303) Potential lack of synchronization in NioEchoServer#AcceptorThread
Date Tue, 10 Apr 2018 04:06:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333251#comment-16333251
] 

Ted Yu edited comment on KAFKA-6303 at 4/10/18 4:05 AM:
--------------------------------------------------------

+1


was (Author: yuzhihong@gmail.com):
lgtm

> Potential lack of synchronization in NioEchoServer#AcceptorThread
> -----------------------------------------------------------------
>
>                 Key: KAFKA-6303
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6303
>             Project: Kafka
>          Issue Type: Bug
>          Components: network
>            Reporter: Ted Yu
>            Assignee: siva santhalingam
>            Priority: Minor
>
> In the run() method:
> {code}
>                                 SocketChannel socketChannel = ((ServerSocketChannel)
key.channel()).accept();
>                                 socketChannel.configureBlocking(false);
>                                 newChannels.add(socketChannel);
> {code}
> Modification to newChannels should be protected by synchronized block.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message