kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4650) Improve test coverage org.apache.kafka.streams.kstream.internals
Date Mon, 09 Apr 2018 18:06:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430988#comment-16430988
] 

Matthias J. Sax commented on KAFKA-4650:
----------------------------------------

I agree that smaller PRs are easier to handle. Not sure if we need multiple tickets -- feel
free to do a "partial PR" that tackles some of the mentioned classes.

> Improve test coverage org.apache.kafka.streams.kstream.internals
> ----------------------------------------------------------------
>
>                 Key: KAFKA-4650
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4650
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>            Reporter: Damian Guy
>            Priority: Minor
>              Labels: newbie
>
> Lots of classes have little or no coverage at all, i.e., 
> {{KTableAggregate.KTableAggregateValueGetter}}
> {{KTableKTableRightJoin.KTableKTableRightJoinValueGetterSupplier}}
> {{KStreamAggregate.KStreamAggregateValueGetter}}
> {{KStreamReduce.KStreamReduceValueGetter}}
> {{KStreamWindowReduce.new KTableValueGetterSupplier}}
> {{KTableAggregate.new KTableValueGetterSupplier}}
> {{KTableRepartitionMap.new KTableValueGetterSupplier}}
> {{KTableKTableRightJoin.KTableKTableRightJoinValueGetter}}
> {{KTableKTableLeftJoinValueGetter}}
> {{KStreamWindowReduce.KStreamWindowReduceValueGetter}}
> {{TimeWindow}}
> {{ChangedSerializer}}
> {{UnlimitedWindow}}
> {{WindowedDeserializer}}
> {{KStreamSessionWindowAggregate.KTableSessionWindowValueGetter}}
> {{KTableRepartitionMap}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message