From jira-return-10444-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Tue Mar 6 02:48:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1181D180608 for ; Tue, 6 Mar 2018 02:48:03 +0100 (CET) Received: (qmail 17320 invoked by uid 500); 6 Mar 2018 01:48:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 17300 invoked by uid 99); 6 Mar 2018 01:48:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2018 01:48:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7FB8FC65C5 for ; Tue, 6 Mar 2018 01:48:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Hh2lxUuRwYLL for ; Tue, 6 Mar 2018 01:48:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1EEB15F3B5 for ; Tue, 6 Mar 2018 01:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6066CE0112 for ; Tue, 6 Mar 2018 01:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 172CD21270 for ; Tue, 6 Mar 2018 01:48:00 +0000 (UTC) Date: Tue, 6 Mar 2018 01:48:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-6611) Re-write simple benchmark in system tests with JMXTool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387130#comment-16387130 ] ASF GitHub Bot commented on KAFKA-6611: --------------------------------------- guozhangwang opened a new pull request #4650: KAFKA-6611: PART I, Use JMXTool in SimpleBenchmark URL: https://github.com/apache/kafka/pull/4650 1. Use JmxMixin for SimpleBenchmark (will remove the self reporting in follow-up PR). 2. Make report interval customizable. 3. Incorporates two other improves to JMXTool: https://github.com/apache/kafka/pull/1241 and https://github.com/apache/kafka/pull/2950 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Re-write simple benchmark in system tests with JMXTool > ------------------------------------------------------ > > Key: KAFKA-6611 > URL: https://issues.apache.org/jira/browse/KAFKA-6611 > Project: Kafka > Issue Type: Improvement > Components: streams > Reporter: Guozhang Wang > Assignee: Guozhang Wang > Priority: Major > > The current SimpleBenchmark is recording the num.records actively in order to compute throughput and latency, which introduces extra cost plus is less accurate for benchmarking purposes; instead, it's better to use JmxMixin with SimpleBenchmark to record metrics. -- This message was sent by Atlassian JIRA (v7.6.3#76005)