From jira-return-11054-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Mar 22 20:27:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1BF62180676 for ; Thu, 22 Mar 2018 20:27:03 +0100 (CET) Received: (qmail 89007 invoked by uid 500); 22 Mar 2018 19:27:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 88996 invoked by uid 99); 22 Mar 2018 19:27:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Mar 2018 19:27:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A45D0180E9E for ; Thu, 22 Mar 2018 19:27:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id IadD-95jUNh8 for ; Thu, 22 Mar 2018 19:27:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 54A575FDF8 for ; Thu, 22 Mar 2018 19:27:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DDC1AE0D83 for ; Thu, 22 Mar 2018 19:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4BD3F214DE for ; Thu, 22 Mar 2018 19:27:00 +0000 (UTC) Date: Thu, 22 Mar 2018 19:27:00 +0000 (UTC) From: "John Roesler (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-6474) Rewrite test to use new public TopologyTestDriver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-6474?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1641= 0162#comment-16410162 ]=20 John Roesler commented on KAFKA-6474: ------------------------------------- Yeah, thanks [~h314to]! I had tried it with just half of that change, and i= t obviously didn't work. I'm really glad you figured that out! FYI, there are other sub-projects in kafka that are going to follow this pa= ttern, so I'm going to start a dev mailing list discussion to share your pa= ttern. Also, for completeness, I had to augment your build.gradle patch slightly t= o get './gradlew streams:test-utils:test' to pass: {noformat} diff --git a/build.gradle b/build.gradle index 5e4c35643..2f38bf28b 100644 --- a/build.gradle +++ b/build.gradle @@ -921,6 +921,7 @@ project(':streams') { testCompile project(':clients').sourceSets.test.output testCompile project(':core') testCompile project(':core').sourceSets.test.output + testCompile project(':streams:test-utils').sourceSets.main.output testCompile libs.junit testCompile libs.easymock testCompile libs.bcpkix @@ -965,11 +966,12 @@ project(':streams:test-utils') { archivesBaseName =3D "kafka-streams-test-utils" dependencies { - compile project(':streams') + compile project(':streams').sourceSets.main.output compile project(':clients') testCompile project(':clients').sourceSets.test.output testCompile libs.junit + testCompile libs.rocksDBJni testRuntime libs.slf4jlog4j }{noformat} The reason is that we are skipping=C2=A0:streams:copyDependantLibs during t= est-utils:compile now (to avoid the circular dependency), so we have to exp= lictly depend in testCompile on any libs that would have been transitively = pulled in from :streams (and are in the test's run-time code path). In case you run into a similar error when you run the full test suite, the = error I saw was: {noformat} java.lang.ClassNotFoundException: org.rocksdb.RocksDBException{noformat} > Rewrite test to use new public TopologyTestDriver > ------------------------------------------------- > > Key: KAFKA-6474 > URL: https://issues.apache.org/jira/browse/KAFKA-6474 > Project: Kafka > Issue Type: Improvement > Components: streams, unit tests > Affects Versions: 1.1.0 > Reporter: Matthias J. Sax > Assignee: Filipe Agapito > Priority: Major > Labels: beginner, newbie > > With KIP-247 we added public TopologyTestDriver. We should rewrite out ow= n test to use this new test driver and remove the two classes ProcessorTopo= ogyTestDriver and KStreamTestDriver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)