kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6716) discardChannel should be released in MockSelector#completeSend
Date Tue, 27 Mar 2018 23:05:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416428#comment-16416428
] 

ASF GitHub Bot commented on KAFKA-6716:
---------------------------------------

huxihx opened a new pull request #4783: KAFKA-6716: Should close the `discardChannel` in completeSend
URL: https://github.com/apache/kafka/pull/4783
 
 
   KAFKA-6716: Should close the `discardChannel` in completeSend
   https://issues.apache.org/jira/browse/KAFKA-6716
   
   Should close the `discardChannel` in MockSelector#completeSend
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> discardChannel should be released in MockSelector#completeSend
> --------------------------------------------------------------
>
>                 Key: KAFKA-6716
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6716
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>     private void completeSend(Send send) throws IOException {
>         // Consume the send so that we will be able to send more requests to the destination
>         ByteBufferChannel discardChannel = new ByteBufferChannel(send.size());
>         while (!send.completed()) {
>             send.writeTo(discardChannel);
>         }
>         completedSends.add(send);
>     }
> {code}
> The {{discardChannel}} should be closed before returning from the method



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message