kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6629) SegmentedCacheFunctionTest does not cover session window serdes
Date Mon, 19 Mar 2018 16:58:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405120#comment-16405120
] 

Guozhang Wang commented on KAFKA-6629:
--------------------------------------

Hello Jagadesh,

In SegmentedCacheFunctionTest.java, WindowKeySchema is used to generate the bytes format for
cached key etc; this effectively is testing the time window serdes (you can look into WindowKeySchema's
internal implementation). However this test code does not use SessionKeySchema which is effectively
using session window serdes.

The goal is to make this test a parameterized one (Junit supports that), to have a schema
that can be configured to be both WindowKeySchema and SessionKeySchema, and run all the test
cases for both of them.

> SegmentedCacheFunctionTest does not cover session window serdes
> ---------------------------------------------------------------
>
>                 Key: KAFKA-6629
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6629
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Guozhang Wang
>            Priority: Major
>              Labels: newbie, unit-test
>
> The SegmentedCacheFunctionTest.java only covers time window serdes, but not session window
serdes. We should fill in this coverage gap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message