kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KAFKA-5846) Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not specified
Date Mon, 26 Mar 2018 16:43:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191405#comment-16191405
] 

Ted Yu edited comment on KAFKA-5846 at 3/26/18 4:42 PM:
--------------------------------------------------------

Patch looks good to me.


was (Author: yuzhihong@gmail.com):
Patch looks good to me .

> Use singleton NoOpConsumerRebalanceListener in subscribe() call where listener is not
specified
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5846
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5846
>             Project: Kafka
>          Issue Type: Task
>          Components: clients
>            Reporter: Ted Yu
>            Assignee: Kamal Chandraprakash
>            Priority: Minor
>
> Currently KafkaConsumer creates instance of NoOpConsumerRebalanceListener for each subscribe()
call where ConsumerRebalanceListener is not specified:
> {code}
>     public void subscribe(Pattern pattern) {
>         subscribe(pattern, new NoOpConsumerRebalanceListener());
> {code}
> We can create a singleton NoOpConsumerRebalanceListener to be used in such scenarios.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message