From jira-return-10196-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Feb 23 06:36:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F0781180652 for ; Fri, 23 Feb 2018 06:36:03 +0100 (CET) Received: (qmail 66886 invoked by uid 500); 23 Feb 2018 05:36:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 66873 invoked by uid 99); 23 Feb 2018 05:36:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Feb 2018 05:36:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8BA1C1A05E0 for ; Fri, 23 Feb 2018 05:36:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id WAsev3AqNV8V for ; Fri, 23 Feb 2018 05:36:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9E6EB5F216 for ; Fri, 23 Feb 2018 05:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BD63DE0226 for ; Fri, 23 Feb 2018 05:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1FFBE2713F for ; Fri, 23 Feb 2018 05:36:00 +0000 (UTC) Date: Fri, 23 Feb 2018 05:36:00 +0000 (UTC) From: "Aditya Vivek (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-6585) Consolidate duplicated logic on reset tools MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373951#comment-16373951 ] Aditya Vivek commented on KAFKA-6585: ------------------------------------- Thanks Jason :) > Consolidate duplicated logic on reset tools > ------------------------------------------- > > Key: KAFKA-6585 > URL: https://issues.apache.org/jira/browse/KAFKA-6585 > Project: Kafka > Issue Type: Improvement > Reporter: Guozhang Wang > Assignee: Aditya Vivek > Priority: Minor > Labels: newbie > > The consumer reset tool and streams reset tool today shares lot of common logics such as resetting to a datetime etc. We can consolidate them into a common class which directly depend on admin client at simply let these tools to use the class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)