From jira-return-9507-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Feb 2 00:47:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 54B20180652 for ; Fri, 2 Feb 2018 00:47:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 439AC160C56; Thu, 1 Feb 2018 23:47:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8C049160C44 for ; Fri, 2 Feb 2018 00:47:03 +0100 (CET) Received: (qmail 23464 invoked by uid 500); 1 Feb 2018 23:47:02 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 23452 invoked by uid 99); 1 Feb 2018 23:47:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 23:47:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 48FED1A6998 for ; Thu, 1 Feb 2018 23:47:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PmMnQbgkVAqn for ; Thu, 1 Feb 2018 23:47:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D2E365F3B8 for ; Thu, 1 Feb 2018 23:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4ABCEE00C6 for ; Thu, 1 Feb 2018 23:47:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0CEAF21301 for ; Thu, 1 Feb 2018 23:47:00 +0000 (UTC) Date: Thu, 1 Feb 2018 23:47:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-6513) New Connect header support doesn't define `converter.type` property correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349517#comment-16349517 ] ASF GitHub Bot commented on KAFKA-6513: --------------------------------------- rhauch opened a new pull request #4512: KAFKA-6513: Corrected how Converters and HeaderConverters are instantiated and configured URL: https://github.com/apache/kafka/pull/4512 The commits for KIP-145 (KAFKA-5142) changed how the Connect workers instantiate and configure the Converters, and also added the ability to do the same for the new HeaderConverters. However, the last few commits removed the default value for the `converter.type` property for Converters and HeaderConverters, and this broke how the internal converters were being created. This change corrects the behavior so that the `converter.type` property is always set by the worker (or by the Plugins class), which means the existing Converter implementations will not have to do this. The built-in JsonConverter, ByteArrayConverter, and StringConverter also implement HeaderConverter which implements Configurable, but the Worker and Plugins methods do not yet use the `Configurable.configure(Map)` method and instead still use the `Converter.configure(Map,boolean)`. Several tests were modified, and a new PluginsTest was added to verify the new behavior in Plugins for instantiating and configuring the Converter and HeaderConverter instances. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > New Connect header support doesn't define `converter.type` property correctly > ----------------------------------------------------------------------------- > > Key: KAFKA-6513 > URL: https://issues.apache.org/jira/browse/KAFKA-6513 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect > Affects Versions: 1.1.0 > Reporter: Randall Hauch > Assignee: Randall Hauch > Priority: Blocker > Fix For: 1.1.0 > > > The recent feature (KAFKA-5142) added a new {{converter.type}} to make the {{Converter}} implementations now implement {{Configurable}}. However, the worker is not correctly setting these new property types and is instead incorrectly assuming the existing {{Converter}} implementations will set them. For example: > {noformat} > Exception in thread "main" org.apache.kafka.common.config.ConfigException: Missing required configuration "converter.type" which has no default value. > at org.apache.kafka.common.config.ConfigDef.parseValue(ConfigDef.java:472) > at org.apache.kafka.common.config.ConfigDef.parse(ConfigDef.java:462) > at org.apache.kafka.common.config.AbstractConfig.(AbstractConfig.java:62) > at org.apache.kafka.connect.storage.ConverterConfig.(ConverterConfig.java:48) > at org.apache.kafka.connect.json.JsonConverterConfig.(JsonConverterConfig.java:59) > at org.apache.kafka.connect.json.JsonConverter.configure(JsonConverter.java:284) > at org.apache.kafka.connect.runtime.isolation.Plugins.newConfiguredPlugin(Plugins.java:77) > at org.apache.kafka.connect.runtime.isolation.Plugins.newConverter(Plugins.java:208) > at org.apache.kafka.connect.runtime.Worker.(Worker.java:107) > at io.confluent.connect.replicator.ReplicatorApp.config(ReplicatorApp.java:104) > at io.confluent.connect.replicator.ReplicatorApp.main(ReplicatorApp.java:60) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)