From jira-return-9706-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Feb 8 03:17:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id EC9BB18065B for ; Thu, 8 Feb 2018 03:17:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DC104160C5C; Thu, 8 Feb 2018 02:17:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F758160C5B for ; Thu, 8 Feb 2018 03:17:05 +0100 (CET) Received: (qmail 24461 invoked by uid 500); 8 Feb 2018 02:17:04 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 24450 invoked by uid 99); 8 Feb 2018 02:17:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 02:17:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C91CD180034 for ; Thu, 8 Feb 2018 02:17:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Bli46C5tmG8m for ; Thu, 8 Feb 2018 02:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 25DB05F5B3 for ; Thu, 8 Feb 2018 02:17:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ECBAFE0237 for ; Thu, 8 Feb 2018 02:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 26B14240FA for ; Thu, 8 Feb 2018 02:17:00 +0000 (UTC) Date: Thu, 8 Feb 2018 02:17:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-5327) Console Consumer should only poll for up to max messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356375#comment-16356375 ] ASF GitHub Bot commented on KAFKA-5327: --------------------------------------- huxihx opened a new pull request #4546: KAFKA-5327: Console Consumer should only poll for up to max messages URL: https://github.com/apache/kafka/pull/4546 Add a check to ensure --max-messages, if set, must be set no smaller than max.poll.records. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Console Consumer should only poll for up to max messages > -------------------------------------------------------- > > Key: KAFKA-5327 > URL: https://issues.apache.org/jira/browse/KAFKA-5327 > Project: Kafka > Issue Type: Improvement > Components: tools > Reporter: Dustin Cote > Assignee: huxihx > Priority: Minor > Fix For: 1.2.0 > > > The ConsoleConsumer has a --max-messages flag that can be used to limit the number of messages consumed. However, the number of records actually consumed is governed by max.poll.records. This means you see one message on the console, but your offset has moved forward a default of 500, which is kind of counterintuitive. It would be good to only commit offsets for messages we have printed to the console. -- This message was sent by Atlassian JIRA (v7.6.3#76005)