From jira-return-9393-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Feb 1 12:43:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 3200718066D for ; Thu, 1 Feb 2018 12:43:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1FE6F160C26; Thu, 1 Feb 2018 11:43:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6FACE160C44 for ; Thu, 1 Feb 2018 12:43:04 +0100 (CET) Received: (qmail 13090 invoked by uid 500); 1 Feb 2018 11:43:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 13034 invoked by uid 99); 1 Feb 2018 11:43:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 11:43:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3E5CA19A911 for ; Thu, 1 Feb 2018 11:43:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VuVwYfklCQgu for ; Thu, 1 Feb 2018 11:43:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5FC775F2C5 for ; Thu, 1 Feb 2018 11:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BAF77E0256 for ; Thu, 1 Feb 2018 11:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2E9EC21E86 for ; Thu, 1 Feb 2018 11:43:00 +0000 (UTC) Date: Thu, 1 Feb 2018 11:43:00 +0000 (UTC) From: "Damian Guy (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-5022) Improve CRC tests so that we verify which fields are included in the CRC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy updated KAFKA-5022: ------------------------------ Fix Version/s: (was: 1.1.0) 1.2.0 > Improve CRC tests so that we verify which fields are included in the CRC > ------------------------------------------------------------------------ > > Key: KAFKA-5022 > URL: https://issues.apache.org/jira/browse/KAFKA-5022 > Project: Kafka > Issue Type: Sub-task > Components: clients, core, producer > Reporter: Ismael Juma > Priority: Major > Fix For: 1.2.0 > > > It would be good to have a test that updates each field in the record/record batch, recomputes the CRC and then asserts that the CRC changes or not depending on whether that field is meant to be part of the CRC or not. -- This message was sent by Atlassian JIRA (v7.6.3#76005)