kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6111) Tests for KafkaZkClient
Date Tue, 20 Feb 2018 09:46:02 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369862#comment-16369862
] 

ASF GitHub Bot commented on KAFKA-6111:
---------------------------------------

smurakozi opened a new pull request #4596: KAFKA-6111: Improve test coverage of KafkaZkClient,
fix bugs found by new tests
URL: https://github.com/apache/kafka/pull/4596
 
 
   New test cases and checks were added to cover most of the functionality in  KafkaZkClient.

   The new tests found two issues:
   - deleteLogDirEventNotifications used wrong paths when it attempted to delete notifications
   - updateBrokerInfoInZk did not throw an exception if the update was not successful.
   
   These issues are also fixed in this PR.
   New tests were added, they discovered the issues mentioned above.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Tests for KafkaZkClient
> -----------------------
>
>                 Key: KAFKA-6111
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6111
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Ismael Juma
>            Assignee: Sandor Murakozi
>            Priority: Major
>             Fix For: 1.2.0
>
>
> Some methods in KafkaZkClient have no tests at the moment and we need to fix that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message