kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5327) Console Consumer should only poll for up to max messages
Date Thu, 08 Feb 2018 02:17:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356375#comment-16356375
] 

ASF GitHub Bot commented on KAFKA-5327:
---------------------------------------

huxihx opened a new pull request #4546: KAFKA-5327: Console Consumer should only poll for
up to max messages
URL: https://github.com/apache/kafka/pull/4546
 
 
   Add a check to ensure --max-messages, if set,  must be set no smaller than max.poll.records.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Console Consumer should only poll for up to max messages
> --------------------------------------------------------
>
>                 Key: KAFKA-5327
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5327
>             Project: Kafka
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Dustin Cote
>            Assignee: huxihx
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The ConsoleConsumer has a --max-messages flag that can be used to limit the number of
messages consumed. However, the number of records actually consumed is governed by max.poll.records.
This means you see one message on the console, but your offset has moved forward a default
of 500, which is kind of counterintuitive. It would be good to only commit offsets for messages
we have printed to the console.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message