kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6456) Improve JavaDoc of SourceTask#poll() to discourage indefinite blocking
Date Wed, 17 Jan 2018 10:31:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328601#comment-16328601
] 

ASF GitHub Bot commented on KAFKA-6456:
---------------------------------------

gunnarmorling opened a new pull request #4432: KAFKA-6456 JavaDoc clarification for SourceTask#poll()
URL: https://github.com/apache/kafka/pull/4432
 
 
   Making clear that implementations of poll() shouldn't block indefinitely in order to allow
the task instance to transition to PAUSED state.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve JavaDoc of SourceTask#poll() to discourage indefinite blocking
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-6456
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6456
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>    Affects Versions: 1.0.0
>            Reporter: Gunnar Morling
>            Priority: Major
>
> The docs of {{poll()}} currently say "This method should block if no data is currently
available". This causes the task from transitioning to PAUSED state, if there's no data available
for a longer period of time. I'd therefore suggest to reword like this:
> {quote}
> This method should block if no data is currently available but return control to Kafka
Connect periodically (by returning null).
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message