kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tanvi Jaywant (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6451) Simplify KStreamReduce
Date Fri, 26 Jan 2018 00:17:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340336#comment-16340336
] 

Tanvi Jaywant commented on KAFKA-6451:
--------------------------------------

[https://github.com/apache/kafka/pull/4477]

Hello, this is my first pull request in Kafka. Please advise/review. Thank you.

 

> Simplify KStreamReduce
> ----------------------
>
>                 Key: KAFKA-6451
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6451
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Matthias J. Sax
>            Assignee: siva santhalingam
>            Priority: Minor
>              Labels: beginner, newbie
>
> If we do aggregations, we drop records with {{key=null}} or {{value=null}}. However,
in {{KStreamReduce}} we only early exit if {{key=null}} and process {{value=null}} – even
if we only update the state with it's old value and also only send the old value downstream
(ie, we still compute the correct result), it's undesired and wasteful and we should early
exit on {{value=null}}, too.
> This problem might occur for {{KStreamAggregate}} or other processors, too, and we need
to double check those to make sure we implement consistent behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message