kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6428) Fail builds on findbugs warnings
Date Sat, 06 Jan 2018 03:48:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314348#comment-16314348
] 

ASF GitHub Bot commented on KAFKA-6428:
---------------------------------------

ewencp opened a new pull request #4398: KAFKA-6428: Generate findbugs output for CI and fail
builds for 'high' level warnings
URL: https://github.com/apache/kafka/pull/4398
 
 
   We already had findbugs running and it looks like sufficient warnings should cause errors.
This PR does a few things. First, it changes to generating xml reports (which CI likes) by
default. We already seem to have the Jenkins plugins setup to consume these, so we should
immediately start seeing the output on Jenkins. This seems better than the current html default
since most devs probably aren't looking at the html reports unless they are specifically looking
at findbugs issues. Second, it explicitly sets the report level we want to trigger failures
on.
   
   I think we were already failing the build based on the current settings, we just didn't
have any high-level warnings. But this sets us up not to only fail the builds but also have
some visibility via jenkins reports.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fail builds on findbugs warnings
> --------------------------------
>
>                 Key: KAFKA-6428
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6428
>             Project: Kafka
>          Issue Type: Improvement
>          Components: build
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>
> Findbugs spots likely bugs, and especially for warnings at the High level, it actually
has pretty good signal for real bugs (or just things that might be risky). We should be failing
builds, especially PRs, if any sufficiently high warnings are listed. We should get this enabled
for that level and then decide if we want to adjust the level of warnings we want to address.
> This likely relates to KAFKA-5887 since findbugs may not be sufficiently maintained for
JDK9 support. In any case, the intent is to fail the build based on whichever tool is used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message