kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6303) Potential lack of synchronization in NioEchoServer#AcceptorThread
Date Sun, 07 Jan 2018 06:37:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315070#comment-16315070
] 

ASF GitHub Bot commented on KAFKA-6303:
---------------------------------------

shivsantham opened a new pull request #4400: KAFKA-6303: Potential lack of synchronization
in NioEchoServer
URL: https://github.com/apache/kafka/pull/4400
 
 
   In the run() method:
   
                                   SocketChannel socketChannel = ((ServerSocketChannel) key.channel()).accept();
                                   socketChannel.configureBlocking(false);
                                   newChannels.add(socketChannel);
   
   Modification to newChannels should be protected by synchronized block.
   
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Potential lack of synchronization in NioEchoServer#AcceptorThread
> -----------------------------------------------------------------
>
>                 Key: KAFKA-6303
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6303
>             Project: Kafka
>          Issue Type: Bug
>          Components: network
>            Reporter: Ted Yu
>            Assignee: siva santhalingam
>            Priority: Minor
>
> In the run() method:
> {code}
>                                 SocketChannel socketChannel = ((ServerSocketChannel)
key.channel()).accept();
>                                 socketChannel.configureBlocking(false);
>                                 newChannels.add(socketChannel);
> {code}
> Modification to newChannels should be protected by synchronized block.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message