kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6253) Improve sink connector topic regex validation
Date Tue, 16 Jan 2018 22:44:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327938#comment-16327938
] 

ASF GitHub Bot commented on KAFKA-6253:
---------------------------------------

jklukas opened a new pull request #4251: KAFKA-6253: Improve sink connector topic regex validation
URL: https://github.com/apache/kafka/pull/4251
 
 
   KAFKA-3073 added topic regex support for sink connectors. The addition requires that you
only specify one of topics or topics.regex settings. This is being validated in one place,
but not during submission of connectors. This PR adds validation at `AbstractHerder.validateConnectorConfig`
and `WorkerConnector.initialize`.
   
   This adds a test of the new behavior to `AbstractHerderTest`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve sink connector topic regex validation
> ---------------------------------------------
>
>                 Key: KAFKA-6253
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6253
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Jeff Klukas
>            Priority: Major
>             Fix For: 1.1.0
>
>
> KAFKA-3073 adds topic regex support for sink connectors. The addition requires that you
only specify one of topics or topics.regex settings. This is being validated in one place,
but not during submission of connectors. We should improve this since this means it's possible
to get a bad connector config into the config topic.
> For more detailed discussion, see https://github.com/apache/kafka/pull/4151#pullrequestreview-77300221



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message