kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Afshartous (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5660) Don't throw TopologyBuilderException during runtime
Date Tue, 30 Jan 2018 22:49:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345943#comment-16345943
] 

Nick Afshartous commented on KAFKA-5660:
----------------------------------------

One question, in {{KStreamBuilder.java}}, there are some try/catch blocks with
{code:java}
  } catch (final org.apache.kafka.streams.errors.TopologyException e) {
            throw new org.apache.kafka.streams.errors.TopologyBuilderException(e);
        }{code}
 

Should these blocks be removed as part of this task ?  If not please advise. 

> Don't throw TopologyBuilderException during runtime
> ---------------------------------------------------
>
>                 Key: KAFKA-5660
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5660
>             Project: Kafka
>          Issue Type: Task
>          Components: streams
>    Affects Versions: 0.11.0.0
>            Reporter: Matthias J. Sax
>            Assignee: Nick Afshartous
>            Priority: Major
>
> {{TopologyBuilderException}} is a pre-runtime exception that should only be thrown {{KafkaStreams#start()}}
is called.
> However, we do throw {{TopologyBuilderException}} within
> - `SourceNodeFactory#getTopics`
> - `ProcessorContextImpl#getStateStore`
> - `StreamPartitionAssignor#prepareTopic `
> (and maybe somewhere else: we should double check if there are other places in the code
like those).
> We should replace those exception with either {{StreamsException}} or with a new exception
type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message