Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@kafka.apache.org
Date: Mon, 4 Dec 2017 17:26:00 +0000 (UTC)
From: "Tobias Gies (JIRA)" <jira@apache.org>
To: jira@kafka.apache.org
Message-ID: <JIRA.13122624.1512406436000.380073.1512408360559@Atlassian.JIRA>
In-Reply-To: <JIRA.13122624.1512406436000@Atlassian.JIRA>
References: <JIRA.13122624.1512406436000@Atlassian.JIRA> <JIRA.13122624.1512406436670@jira-lw-us.apache.org>
Subject: [jira] [Updated] (KAFKA-6308) Connect: Struct equals/hashCode
 method should use Arrays#deep* methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 04 Dec 2017 17:26:05 -0000


     [ https://issues.apache.org/jira/browse/KAFKA-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Gies updated KAFKA-6308:
-------------------------------
    Summary: Connect: Struct equals/hashCode method should use Arrays#deep* methods  (was: Connect: Struct#equals should use Arrays#deepEquals)

> Connect: Struct equals/hashCode method should use Arrays#deep* methods
> ----------------------------------------------------------------------
>
>                 Key: KAFKA-6308
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6308
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 1.0.0
>            Reporter: Tobias Gies
>              Labels: easyfix, newbie
>
> At the moment, {{org.apache.kafka.connect.data.Struct#equals}} checks two things, after ensuring the incoming {{Object o}} is indeed of the correct type:
> * Whether the schemas of {{this}} and {{o}} are equal, via {{Objects#equals}}
> * Whether the values of {{this}} and {{o}} are qual, via {{Arrays#equals}}.
> The latter check is problematic. {{Arrays#equals}} is meant for one-dimensional arrays of any kind, and thus simply checks the {{equals}} methods of all corresponding elements of its parameters {{a1}} and {{a2}}. However, elements of the {{Struct#values}} array may themselves be arrays in a specific case, namely if a field has a {{BYTES}} Schema Type and the user's input for this field is of type {{byte[]}}.
> Given that, I would suggest to use {{Arrays#deepEquals}} to compare the {{values}} arrays of two {{Struct}} instances. It would solve one of the two issues with {{byte[]}} values mentioned the comment in lines 54-56 of Struct.java.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)