kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6342) Move workaround for JSON parsing of non-escaped strings
Date Wed, 13 Dec 2017 11:28:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289131#comment-16289131
] 

ASF GitHub Bot commented on KAFKA-6342:
---------------------------------------

GitHub user umesh9794 opened a pull request:

    https://github.com/apache/kafka/pull/4321

    KAFKA-6342 : Move workaround for JSON parsing of non-escaped strings

    This PR moves the JSON parsing workaround of [this PR](https://github.com/apache/kafka/pull/4303)
to new method and uses this method in `ZkClient` etc. classes.
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/umesh9794/kafka KAFKA-6342

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4321
    
----
commit ec8abab0629ecdea4a3a5970653e4c88025b8dfd
Author: umesh chaudhary <umesh9794@gmail.com>
Date:   2017-12-13T10:51:23Z

    Initial Commit

----


> Move workaround for JSON parsing of non-escaped strings
> -------------------------------------------------------
>
>                 Key: KAFKA-6342
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6342
>             Project: Kafka
>          Issue Type: Task
>          Components: core
>            Reporter: Rajini Sivaram
>            Assignee: Umesh Chaudhary
>             Fix For: 1.1.0
>
>
> KAFKA-6319 added a workaround to parse invalid JSON persisted using older versions of
Kafka because special characters were not escaped. The workaround is required in 1.0.1 to
enable parsing invalid JSON from ACL configs in ZooKeeper. We can move the workaround out
of kafka.utils.Json#parseFull for 1.1.0 so that it is applied only to ACLs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message