kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6323) punctuate with WALL_CLOCK_TIME triggered immediately
Date Thu, 07 Dec 2017 08:38:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281498#comment-16281498
] 

ASF GitHub Bot commented on KAFKA-6323:
---------------------------------------

GitHub user fredfp opened a pull request:

    https://github.com/apache/kafka/pull/4301

    KAFKA-6323: punctuate with WALL_CLOCK_TIME triggered immediately

    This is the only way I found to fix the issue without altering the API.
    
    @mihbor @mjsax 
    
    the contribution is my original work and I license the work to the project under the project's
open source license

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fredfp/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4301
    
----
commit 0c9b6cac6a5de8e6db81e6ae6f42fe8933012621
Author: Frederic Arno <fredericarno@gmail.com>
Date:   2017-12-07T08:18:42Z

    KAFKA-6323: fix punctuate with WALL_CLOCK_TIME triggered immediately

----


> punctuate with WALL_CLOCK_TIME triggered immediately
> ----------------------------------------------------
>
>                 Key: KAFKA-6323
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6323
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Frederic Arno
>             Fix For: 1.0.1
>
>
> When working on a custom Processor from which I am scheduling a punctuation using WALL_CLOCK_TIME.
I've noticed that whatever the punctuation interval I set, a call to my Punctuator is always
triggered immediately.
> Having a quick look at kafka-streams' code, I could find that all PunctuationSchedule's
timestamps are matched against the current time in order to decide whether or not to trigger
the punctuator (org.apache.kafka.streams.processor.internals.PunctuationQueue#mayPunctuate).
However, I've only seen code that initializes PunctuationSchedule's timestamp to 0, which
I guess is what is causing an immediate punctuation.
> At least when using WALL_CLOCK_TIME, shouldn't the PunctuationSchedule's timestamp be
initialized to current time + interval?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message