Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 39ED0200D43 for ; Tue, 21 Nov 2017 18:07:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 38857160BFC; Tue, 21 Nov 2017 17:07:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 56D7E160BE3 for ; Tue, 21 Nov 2017 18:07:05 +0100 (CET) Received: (qmail 28383 invoked by uid 500); 21 Nov 2017 17:07:04 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 28372 invoked by uid 99); 21 Nov 2017 17:07:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 17:07:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B8E40180710 for ; Tue, 21 Nov 2017 17:07:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id WHTI-4RQPl7n for ; Tue, 21 Nov 2017 17:07:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A251561056 for ; Tue, 21 Nov 2017 17:07:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E0333E25A0 for ; Tue, 21 Nov 2017 17:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4AA7F255B0 for ; Tue, 21 Nov 2017 17:07:00 +0000 (UTC) Date: Tue, 21 Nov 2017 17:07:00 +0000 (UTC) From: "Alexis Sellier (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-6252) A metric named 'XX' already exists, can't register another one. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Nov 2017 17:07:06 -0000 [ https://issues.apache.org/jira/browse/KAFKA-6252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Sellier updated KAFKA-6252: ---------------------------------- Description: When a connector crashes, It cannot be restarted and an exception like this is thrown {code:java} java.lang.IllegalArgumentException: A metric named 'MetricName [name=offset-commit-max-time-ms, group=connector-task-metrics, description=The maximum time in milliseconds taken by this task to commit offsets., tags={connector=hdfs-sink-connector-recover, task=0}]' already exists, can't register another one. at org.apache.kafka.common.metrics.Metrics.registerMetric(Metrics.java:532) at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:256) at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:241) at org.apache.kafka.connect.runtime.WorkerTask$TaskMetricsGroup.(WorkerTask.java:328) at org.apache.kafka.connect.runtime.WorkerTask.(WorkerTask.java:69) at org.apache.kafka.connect.runtime.WorkerSinkTask.(WorkerSinkTask.java:98) at org.apache.kafka.connect.runtime.Worker.buildWorkerTask(Worker.java:449) at org.apache.kafka.connect.runtime.Worker.startTask(Worker.java:404) at org.apache.kafka.connect.runtime.distributed.DistributedHerder.startTask(DistributedHerder.java:852) at org.apache.kafka.connect.runtime.distributed.DistributedHerder.access$1600(DistributedHerder.java:108) at org.apache.kafka.connect.runtime.distributed.DistributedHerder$13.call(DistributedHerder.java:866) at org.apache.kafka.connect.runtime.distributed.DistributedHerder$13.call(DistributedHerder.java:862) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) {code} I guess it's because the function taskMetricsGroup.close is not call in all the cases was: When a connector crashes, It cannot be restarted and an exception like this is thrown {code:java} java.lang.IllegalArgumentException: A metric named 'MetricName [name=offset-commit-max-time-ms, group=connector-task-metrics, description=The maximum time in milliseconds taken by this task to commit offsets., tags={connector=hdfs-sink-connector-recover, task=0}]' already exists, can't register another one. at org.apache.kafka.common.metrics.Metrics.registerMetric(Metrics.java:532) at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:256) at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:241) at org.apache.kafka.connect.runtime.WorkerTask$TaskMetricsGroup.(WorkerTask.java:328) at org.apache.kafka.connect.runtime.WorkerTask.(WorkerTask.java:69) at org.apache.kafka.connect.runtime.WorkerSinkTask.(WorkerSinkTask.java:98) at org.apache.kafka.connect.runtime.Worker.buildWorkerTask(Worker.java:449) at org.apache.kafka.connect.runtime.Worker.startTask(Worker.java:404) at org.apache.kafka.connect.runtime.distributed.DistributedHerder.startTask(DistributedHerder.java:852) at org.apache.kafka.connect.runtime.distributed.DistributedHerder.access$1600(DistributedHerder.java:108) at org.apache.kafka.connect.runtime.distributed.DistributedHerder$13.call(DistributedHerder.java:866) at org.apache.kafka.connect.runtime.distributed.DistributedHerder$13.call(DistributedHerder.java:862) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) {code} I guess it's because the function taskMetricsGroup.close in not call in all the cases > A metric named 'XX' already exists, can't register another one. > --------------------------------------------------------------- > > Key: KAFKA-6252 > URL: https://issues.apache.org/jira/browse/KAFKA-6252 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect > Affects Versions: 1.0.0 > Environment: Linux > Reporter: Alexis Sellier > > When a connector crashes, It cannot be restarted and an exception like this is thrown > {code:java} > java.lang.IllegalArgumentException: A metric named 'MetricName [name=offset-commit-max-time-ms, group=connector-task-metrics, description=The maximum time in milliseconds taken by this task to commit offsets., tags={connector=hdfs-sink-connector-recover, task=0}]' already exists, can't register another one. > at org.apache.kafka.common.metrics.Metrics.registerMetric(Metrics.java:532) > at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:256) > at org.apache.kafka.common.metrics.Sensor.add(Sensor.java:241) > at org.apache.kafka.connect.runtime.WorkerTask$TaskMetricsGroup.(WorkerTask.java:328) > at org.apache.kafka.connect.runtime.WorkerTask.(WorkerTask.java:69) > at org.apache.kafka.connect.runtime.WorkerSinkTask.(WorkerSinkTask.java:98) > at org.apache.kafka.connect.runtime.Worker.buildWorkerTask(Worker.java:449) > at org.apache.kafka.connect.runtime.Worker.startTask(Worker.java:404) > at org.apache.kafka.connect.runtime.distributed.DistributedHerder.startTask(DistributedHerder.java:852) > at org.apache.kafka.connect.runtime.distributed.DistributedHerder.access$1600(DistributedHerder.java:108) > at org.apache.kafka.connect.runtime.distributed.DistributedHerder$13.call(DistributedHerder.java:866) > at org.apache.kafka.connect.runtime.distributed.DistributedHerder$13.call(DistributedHerder.java:862) > at java.util.concurrent.FutureTask.run(FutureTask.java:266) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > {code} > I guess it's because the function taskMetricsGroup.close is not call in all the cases -- This message was sent by Atlassian JIRA (v6.4.14#64029)