Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@kafka.apache.org
Date: Fri, 17 Nov 2017 09:47:00 +0000 (UTC)
From: =?utf-8?Q?S=C3=B6nke_Liebau_=28JIRA=29?= <jira@apache.org>
To: jira@kafka.apache.org
Message-ID: <JIRA.13085169.1499337274000.265197.1510912020441@Atlassian.JIRA>
In-Reply-To: <JIRA.13085169.1499337274000@Atlassian.JIRA>
References: <JIRA.13085169.1499337274000@Atlassian.JIRA> <JIRA.13085169.1499337274838@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-5563) Clarify handling of connector name
 in config
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 17 Nov 2017 09:47:05 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-5563?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1625=
6744#comment-16256744 ]=20

S=C3=B6nke Liebau commented on KAFKA-5563:
-------------------------------------

As KAFKA-4930 is approaching a stable state I looked at this again and foun=
d that a check like this is already implemented for [updating a connectorco=
nfig|https://github.com/apache/kafka/blob/e31c0c9bdbad432bc21b583bd3c084f05=
323f642/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest=
/resources/ConnectorsResource.java#L135]=20

I've prepared a pull request that moves this check into a small helper func=
tion and call this from the createConnector method as well.=20

I've also tested merging this with the PR for 4930 which works nicely (for =
now), if any problems occur I'll rebase whichever PR gets merged later.

> Clarify handling of connector name in config=20
> ---------------------------------------------
>
>                 Key: KAFKA-5563
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5563
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.11.0.0
>            Reporter: S=C3=B6nke Liebau
>            Assignee: S=C3=B6nke Liebau
>            Priority: Minor
>
> The connector name is currently being stored in two places, once at the r=
oot level of the connector and once in the config:
> {code:java}
> {
> =09"name": "test",
> =09"config": {
> =09=09"connector.class": "org.apache.kafka.connect.tools.MockSinkConnecto=
r",
> =09=09"tasks.max": "3",
> =09=09"topics": "test-topic",
> =09=09"name": "test"
> =09},
> =09"tasks": [
> =09=09{
> =09=09=09"connector": "test",
> =09=09=09"task": 0
> =09=09}
> =09]
> }
> {code}
> If no name is provided in the "config" element, then the name from the ro=
ot level is [copied there when the connector is being created|https://githu=
b.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafk=
a/connect/runtime/rest/resources/ConnectorsResource.java#L95]. If however a=
 name is provided in the config then it is not touched, which means it is p=
ossible to create a connector with a different name at the root level and i=
n the config like this:
> {code:java}
> {
> =09"name": "test1",
> =09"config": {
> =09=09"connector.class": "org.apache.kafka.connect.tools.MockSinkConnecto=
r",
> =09=09"tasks.max": "3",
> =09=09"topics": "test-topic",
> =09=09"name": "differentname"
> =09},
> =09"tasks": [
> =09=09{
> =09=09=09"connector": "test1",
> =09=09=09"task": 0
> =09=09}
> =09]
> }
> {code}
> I am not aware of any issues that this currently causes, but it is at lea=
st confusing and probably not intended behavior and definitely bears potent=
ial for bugs, if different functions take the name from different places.
> Would it make sense to add a check to reject requests that provide differ=
ent names in the request and the config section?


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)