kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6253) Improve sink connector topic regex validation
Date Wed, 22 Nov 2017 18:20:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263058#comment-16263058
] 

ASF GitHub Bot commented on KAFKA-6253:
---------------------------------------

GitHub user jklukas opened a pull request:

    https://github.com/apache/kafka/pull/4251

    KAFKA-6253: Improve sink connector topic regex validation

    KAFKA-3073 added topic regex support for sink connectors. The addition requires that you
only specify one of topics or topics.regex settings. This is being validated in one place,
but not during submission of connectors. This PR adds validation at `AbstractHerder.validateConnectorConfig`
and `WorkerConnector.initialize`.
    
    This adds a test of the new behavior to `AbstractHerderTest`.
    
    ### Committer Checklist (excluded from commit message)
    - [ ] Verify design and implementation 
    - [ ] Verify test coverage and CI build status
    - [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jklukas/kafka connect-topics-validation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4251.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4251
    
----
commit 830f1b627f6ba2d76f72626fac0741380d03a010
Author: Jeff Klukas <jeff@klukas.net>
Date:   2017-11-22T17:42:56Z

    KAFKA-6253: Improve sink connector topic regex validation

----


> Improve sink connector topic regex validation
> ---------------------------------------------
>
>                 Key: KAFKA-6253
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6253
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Jeff Klukas
>             Fix For: 1.1.0
>
>
> KAFKA-3073 adds topic regex support for sink connectors. The addition requires that you
only specify one of topics or topics.regex settings. This is being validated in one place,
but not during submission of connectors. We should improve this since this means it's possible
to get a bad connector config into the config topic.
> For more detailed discussion, see https://github.com/apache/kafka/pull/4151#pullrequestreview-77300221



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message