kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charly Molter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6180) AbstractConfig.getList() should never return null
Date Wed, 08 Nov 2017 10:57:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243710#comment-16243710
] 

Charly Molter commented on KAFKA-6180:
--------------------------------------

I don't have the Jira access to assign myself but I've just opened a PR for this.

> AbstractConfig.getList() should never return null
> -------------------------------------------------
>
>                 Key: KAFKA-6180
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6180
>             Project: Kafka
>          Issue Type: Improvement
>          Components: config
>    Affects Versions: 0.10.1.0, 0.10.1.1, 0.10.2.0, 0.10.2.1, 0.11.0.0, 1.0.0
>            Reporter: Charly Molter
>            Priority: Trivial
>
> AbstractConfig.getList returns null if the property is unset and there's no default.
> This creates a lot of cases where we need to do null checks (and remember them).
> It's good practice to just return an empty list as usually code naturally handles empty
lists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message