kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6138) Simplify StreamsBuilder#addGlobalStore
Date Fri, 17 Nov 2017 04:23:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256453#comment-16256453
] 

Guozhang Wang commented on KAFKA-6138:
--------------------------------------

[~Sandeep S] I think Matthias' point here is that, unlike the {{Topology}} which belongs to
the lower-level PAPI layer and hence users are required to provide the sourceName / processorName,
{{StreamsBuilder}} belongs to the higher-level DSL layer which can auto-generate the sourceName
and processorName, so we can remove these two parameters to not enforce users to specify them,
and instead only have:

{code}
addGlobalStore(final StoreBuilder storeBuilder,
                                                final Deserializer keyDeserializer,
                                                final Deserializer valueDeserializer,
                                                final String topic,
                                                final ProcessorSupplier stateUpdateSupplier)
{code}

> Simplify StreamsBuilder#addGlobalStore
> --------------------------------------
>
>                 Key: KAFKA-6138
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6138
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Matthias J. Sax
>              Labels: beginner, needs-kip, newbie
>
> {{StreamsBuilder#addGlobalStore}} is a 1:1 copy of {{Topology#addGlobalStore}}. However,
at DSL level we can actually auto-generate the two processor names and thus simplify the interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message