kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5936) KafkaProducer should not wrap InterruptedException in close() with KafkaException
Date Thu, 30 Nov 2017 00:48:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271920#comment-16271920
] 

ASF GitHub Bot commented on KAFKA-5936:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3912


> KafkaProducer should not wrap InterruptedException in close() with KafkaException
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-5936
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5936
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 0.11.0.0, 0.11.0.1, 1.0.0
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>             Fix For: 1.0.1
>
>
> {{KafkaProducer.close()}} catches an {{InterruptedException}} when joining the sender
thread and rethrows it later as a {{KafkaException}}. This prevent the interrupt signal to
bubble out of the producer and thus, the caller might miss the interrupt.
> We should rather throw our own {{org.apache.kafka.common.errors.InterruptException}}
similar to {{KafkaConsumer}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message