Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@kafka.apache.org
Date: Sat, 21 Oct 2017 07:08:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: jira@kafka.apache.org
Message-ID: <JIRA.13107855.1507479378000.26247.1508569680086@Atlassian.JIRA>
In-Reply-To: <JIRA.13107855.1507479378000@Atlassian.JIRA>
References: <JIRA.13107855.1507479378000@Atlassian.JIRA> <JIRA.13107855.1507479378502@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-6024) Consider moving validation in
 KafkaConsumer ahead of call to acquireAndEnsureOpen()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sat, 21 Oct 2017 07:08:07 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-6024?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1621=
3773#comment-16213773 ]=20

ASF GitHub Bot commented on KAFKA-6024:
---------------------------------------

GitHub user shivsantham opened a pull request:

    https://github.com/apache/kafka/pull/4109

    KAFKA-6024 - Move validation in KafkaConsumer ahead of acquireAndEnsu=
=E2=80=A6

    In several methods, parameter validation is done after calling acquireA=
ndEnsureOpen() in Kafka Consumer :
   =20
        public void seek(TopicPartition partition, long offset) {
            acquireAndEnsureOpen();
            try {
                if (offset < 0)
                    throw new IllegalArgumentException("seek offset must no=
t be a negative number");
   =20
    Since the value of parameter would not change per invocation, it seems =
performing validation ahead of acquireAndEnsureOpen() call would be better.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shivsantham/kafka kafka-6024

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4109
   =20
----
commit 79b6fbcff617f6412798d6395b3378df5dd601ed
Author: siva santhalingam <siva.santhalingam@gmail.com>
Date:   2017-10-21T07:05:03Z

    KAFKA-6024 - Move validation in KafkaConsumer ahead of acquireAndEnsure=
Open()

----


> Consider moving validation in KafkaConsumer ahead of call to acquireAndEn=
sureOpen()
> -------------------------------------------------------------------------=
----------
>
>                 Key: KAFKA-6024
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6024
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: siva santhalingam
>            Priority: Minor
>
> In several methods, parameter validation is done after calling acquireAnd=
EnsureOpen() :
> {code}
>     public void seek(TopicPartition partition, long offset) {
>         acquireAndEnsureOpen();
>         try {
>             if (offset < 0)
>                 throw new IllegalArgumentException("seek offset must not =
be a negative number");
> {code}
> Since the value of parameter would not change per invocation, it seems pe=
rforming validation ahead of acquireAndEnsureOpen() call would be better.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)