Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3396E200D0A for ; Wed, 4 Oct 2017 20:18:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 31D53160BD7; Wed, 4 Oct 2017 18:18:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 792E61609D6 for ; Wed, 4 Oct 2017 20:18:04 +0200 (CEST) Received: (qmail 28143 invoked by uid 500); 4 Oct 2017 18:18:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 28131 invoked by uid 99); 4 Oct 2017 18:18:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Oct 2017 18:18:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EC4E7180C1E for ; Wed, 4 Oct 2017 18:18:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hOpcWLZ_VQGt for ; Wed, 4 Oct 2017 18:18:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D18CD5FB2F for ; Wed, 4 Oct 2017 18:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 16726E0E4F for ; Wed, 4 Oct 2017 18:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7DDC4242F8 for ; Wed, 4 Oct 2017 18:18:00 +0000 (UTC) Date: Wed, 4 Oct 2017 18:18:00 +0000 (UTC) From: "Ewen Cheslack-Postava (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 04 Oct 2017 18:18:05 -0000 Ewen Cheslack-Postava created KAFKA-6011: -------------------------------------------- Summary: AppInfoParser should only use metrics API and should not register JMX mbeans directly Key: KAFKA-6011 URL: https://issues.apache.org/jira/browse/KAFKA-6011 Project: Kafka Issue Type: Bug Components: metrics Reporter: Ewen Cheslack-Postava Priority: Minor AppInfoParser collects info about the app ID, version, and commit ID and logs them + exposes corresponding metrics. For some reason we ended up with the app ID metric being registered directly to JMX while the version and commit ID use the metrics API. This means the app ID would not be accessible to custom metrics reporter. This isn't a huge loss as this is probably a rarely used metric, but we should really only be using the metrics API. Only using the metrics API would also reduce and centralize the places we need to do name mangling to handle characters that might not be valid for metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)