Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B6E7B200D37 for ; Thu, 26 Oct 2017 00:34:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B55A0160BE0; Wed, 25 Oct 2017 22:34:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 06D0E160BDA for ; Thu, 26 Oct 2017 00:34:03 +0200 (CEST) Received: (qmail 67632 invoked by uid 500); 25 Oct 2017 22:34:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 67620 invoked by uid 99); 25 Oct 2017 22:34:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Oct 2017 22:34:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 554DDC4661 for ; Wed, 25 Oct 2017 22:34:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id VJpVR3uTpdO6 for ; Wed, 25 Oct 2017 22:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 67DD25FC1C for ; Wed, 25 Oct 2017 22:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 02254E0D5C for ; Wed, 25 Oct 2017 22:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A9F1C212F5 for ; Wed, 25 Oct 2017 22:34:00 +0000 (UTC) Date: Wed, 25 Oct 2017 22:34:00 +0000 (UTC) From: "Kevin Lu (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (KAFKA-5991) Change Consumer per partition lag metrics to put topic-partition-id in tags instead of metric name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 25 Oct 2017 22:34:04 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Lu updated KAFKA-5991: ---------------------------- Description: [KIP-92|https://cwiki.apache.org/confluence/display/KAFKA/KIP-92+-+Add+per+partition+lag+metrics+to+KafkaConsumer] brought per partition lag metrics to {{KafkaConsumer}}, but these metrics put the {{TOPIC-PARTITION_ID}} inside of the metric name itself. These metrics should instead utilize the tags and put {{key="topic-partition"}} and {{value=${TOPIC-PARTITION_ID}}}. Per-broker (node) and per-topic metrics utilize tags in this way by putting {{key="node/topic"}} and {{value=${NODE_ID}/${TOPIC_NAME}{}}}. I'm guessing a KIP is needed for this as this changes a public API (metric)? was: [KIP-92|https://cwiki.apache.org/confluence/display/KAFKA/KIP-92+-+Add+per+partition+lag+metrics+to+KafkaConsumer] brought per partition lag metrics to {{KafkaConsumer}}, but these metrics put the {{TOPIC-PARTITION_ID}} inside of the metric name itself. These metrics should instead utilize the tags and put {{key="topic-partition"}} and {{value="TOPIC-PARTITION_ID"}}. Per-broker (node) and per-topic metrics utilize tags in this way by putting {{key="node/topic"}} and {{value="NODE_ID/TOPIC_NAME"{}}}. I'm guessing a KIP is needed for this as this changes a public API (metric)? > Change Consumer per partition lag metrics to put topic-partition-id in tags instead of metric name > -------------------------------------------------------------------------------------------------- > > Key: KAFKA-5991 > URL: https://issues.apache.org/jira/browse/KAFKA-5991 > Project: Kafka > Issue Type: Improvement > Components: metrics > Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.0, 0.10.2.0, 0.11.0.0 > Reporter: Kevin Lu > Priority: Minor > Labels: metrics > > [KIP-92|https://cwiki.apache.org/confluence/display/KAFKA/KIP-92+-+Add+per+partition+lag+metrics+to+KafkaConsumer] brought per partition lag metrics to {{KafkaConsumer}}, but these metrics put the {{TOPIC-PARTITION_ID}} inside of the metric name itself. These metrics should instead utilize the tags and put {{key="topic-partition"}} and {{value=${TOPIC-PARTITION_ID}}}. > Per-broker (node) and per-topic metrics utilize tags in this way by putting {{key="node/topic"}} and {{value=${NODE_ID}/${TOPIC_NAME}{}}}. > I'm guessing a KIP is needed for this as this changes a public API (metric)? -- This message was sent by Atlassian JIRA (v6.4.14#64029)