kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6130) VerifiableConsumer with --max-messages doesn't exit
Date Mon, 30 Oct 2017 11:10:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224708#comment-16224708

ASF GitHub Bot commented on KAFKA-6130:

GitHub user tombentley opened a pull request:


    KAFKA-6130: VerifiableConsumer with --max-messages

    @hachikuji can you review this? Do you know the best place to write a test, since there
doesn't seem to be a unit test for the `VerifiableConsumer`?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tombentley/kafka KAFKA-6130-verifiable-consumer-max-messages

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4157
commit 7ee4341babbf9616594169cf6c5cf2d093870d4e
Author: Tom Bentley <tbentley@redhat.com>
Date:   2017-10-26T10:41:15Z

    KAFKA-6130: VerifiableConsumer with --max-messages


> VerifiableConsumer with --max-messages doesn't exit
> ---------------------------------------------------
>                 Key: KAFKA-6130
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6130
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Tom Bentley
>            Assignee: Tom Bentley
>            Priority: Minor
> If I run {{kafka-verifiable-consumer.sh --max-messages=N}} I expect the tool to consume
N messages and then exit. It will actually consume as many messages as are in the topic and
then block.
> The problem is that although  the max messages will cause the loop in onRecordsReceived()
to break, the loop in run() will just call onRecordsReceived() again.

This message was sent by Atlassian JIRA

View raw message