kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Lu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6123) MetricsReporter does not get auto-generated client.id
Date Thu, 26 Oct 2017 21:18:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221248#comment-16221248
] 

Kevin Lu commented on KAFKA-6123:
---------------------------------

[~guozhang]

May I work on this?

Does this require a KIP?

> MetricsReporter does not get auto-generated client.id
> -----------------------------------------------------
>
>                 Key: KAFKA-6123
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6123
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients, metrics
>    Affects Versions: 0.11.0.0
>            Reporter: Kevin Lu
>            Priority: Minor
>              Labels: clients, metrics, newbie++
>
> When a {{MetricsReporter}} is configured for a client, it will receive the user-specified
configurations via {{Configurable.configure(Map<String, ?> configs)}}. Likewise, {{ProducerInterceptor}}
and {{ConsumerInterceptor}} receive user-specified configurations in their configure methods.

> The difference is when a user does not specify the {{client.id}} field, Kafka will auto-generate
client ids (producer-1, producer-2, consumer-1, consumer-2, etc). This auto-generated {{client.id}}
will be passed into the interceptors' configure method, but it is not passed to the {{MetricsReporter}}
configure method.
> This makes it harder to directly map {{MetricsReporter}} with the interceptors for the
client when users do not specify the {{client.id}} field. The {{client.id}} can be determined
from identifying a metric with the {{client.id}} tag, but this is hacky and requires traversal.

> It would be useful to have auto-generated {{client.id}} field also passed to the {{MetricsReporter}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message