kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6115) TaskManager should be type aware
Date Tue, 24 Oct 2017 23:44:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217886#comment-16217886
] 

ASF GitHub Bot commented on KAFKA-6115:
---------------------------------------

GitHub user mjsax opened a pull request:

    https://github.com/apache/kafka/pull/4129

    KAFKA-6115: TaskManager should be type aware

     - remove type specific methods from Task interface
     - add generics to preserve task type
     - add sub classes for different task types

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/kafka kafka-6115-taskManager-should-be-type-aware

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4129.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4129
    
----
commit 48baeb368cb8072669780506f56afde084c943d9
Author: Matthias J. Sax <matthias@confluent.io>
Date:   2017-10-24T23:39:34Z

    KAFKA-6115: TaskManager should be type aware
     - remove type specific methods from Task interface
     - add generics to preserve task type
     - add sub classes for different task types

----


> TaskManager should be type aware
> --------------------------------
>
>                 Key: KAFKA-6115
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6115
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>             Fix For: 1.1.0
>
>
> Currently, in {{TaskManager}} we don't distinguish between {{StreamTask}} and {{StandbyTask}}.
However, both have quite different live cycles and thus we should try do distinguish between
both.
> This also affect interface {{Task}} that should only contain method we need for both
type of tasks, but not contain sub type specific methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message