kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6105) group.id is not picked by kafka.tools.EndToEndLatency
Date Mon, 23 Oct 2017 08:16:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214801#comment-16214801
] 

ASF GitHub Bot commented on KAFKA-6105:
---------------------------------------

GitHub user cnZach opened a pull request:

    https://github.com/apache/kafka/pull/4116

    KAFKA-6105: load client properties in proper order for EndToEndLatency tool

    Currently, the property file is loaded first, and later a auto generated group.id is used:
    `consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" + System.currentTimeMillis())`
    
    so even user gives the group.id in a property file, it is not picked up.
    
    Change it to load client properties in proper order: set default values first, then try
to load the custom values set in client.properties file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cnZach/kafka cnZach_KAFKA-6105

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4116
    
----
commit 99b6ce136d1c4bafa0f74828583d6b4af6cb0785
Author: Yuexin Zhang <zach.yx.zhang@gmail.com>
Date:   2017-10-23T08:11:45Z

    load client properties in proper order: set default values first, then try to load the
custom values set in client.properties file

----


> group.id is not picked by kafka.tools.EndToEndLatency
> -----------------------------------------------------
>
>                 Key: KAFKA-6105
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6105
>             Project: Kafka
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 0.11.0.0
>            Reporter: Yuexin Zhang
>
> As per these lines:
> https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/EndToEndLatency.scala#L64-L67
> the property file is loaded first, and later a auto generated group.id is used:
> consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, "test-group-" + System.currentTimeMillis())
> so even user gives the group.id in a property file, it is not picked up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message