[ https://issues.apache.org/jira/browse/KAFKA-6024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196244#comment-16196244
]
Ted Yu commented on KAFKA-6024:
-------------------------------
Go ahead.
> Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()
> -----------------------------------------------------------------------------------
>
> Key: KAFKA-6024
> URL: https://issues.apache.org/jira/browse/KAFKA-6024
> Project: Kafka
> Issue Type: Improvement
> Reporter: Ted Yu
> Priority: Minor
>
> In several methods, parameter validation is done after calling acquireAndEnsureOpen()
:
> {code}
> public void seek(TopicPartition partition, long offset) {
> acquireAndEnsureOpen();
> try {
> if (offset < 0)
> throw new IllegalArgumentException("seek offset must not be a negative
number");
> {code}
> Since the value of parameter would not change per invocation, it seems performing validation
ahead of acquireAndEnsureOpen() call would be better.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
|