kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajini Sivaram (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-6011) AppInfoParser should only use metrics API and should not register JMX mbeans directly
Date Wed, 04 Oct 2017 20:31:01 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191994#comment-16191994
] 

Rajini Sivaram commented on KAFKA-6011:
---------------------------------------

The id that is passed to {{AppInfoParser}} by KafkaProducer, KafkaConsumer and KafkaAdminClient
is the client-id which is set as a tag for commit-id and version metrics. Do we really need
to duplicate this as a separate metric?

> AppInfoParser should only use metrics API and should not register JMX mbeans directly
> -------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6011
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6011
>             Project: Kafka
>          Issue Type: Bug
>          Components: metrics
>            Reporter: Ewen Cheslack-Postava
>            Priority: Minor
>
> AppInfoParser collects info about the app ID, version, and commit ID and logs them +
exposes corresponding metrics. For some reason we ended up with the app ID metric being registered
directly to JMX while the version and commit ID use the metrics API. This means the app ID
would not be accessible to custom metrics reporter.
> This isn't a huge loss as this is probably a rarely used metric, but we should really
only be using the metrics API. Only using the metrics API would also reduce and centralize
the places we need to do name mangling to handle characters that might not be valid for metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message