kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5988) Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE
Date Wed, 04 Oct 2017 19:25:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191880#comment-16191880
] 

Guozhang Wang commented on KAFKA-5988:
--------------------------------------

Yeah the rationale of using a static field is to avoid the case when multiple `KafkaStreams`
instances get created within the same JVM, in which case thread namings will conflict.

> Consider removing StreamThread#STREAM_THREAD_ID_SEQUENCE
> --------------------------------------------------------
>
>                 Key: KAFKA-5988
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5988
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: siva santhalingam
>            Priority: Minor
>
> StreamThread#STREAM_THREAD_ID_SEQUENCE is used for naming (numbering) StreamThread's
.
> It is used in create() which is called from a loop in KafkaStreams ctor.
> We can remove STREAM_THREAD_ID_SEQUENCE and pass the loop index to create()



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message