kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5848) KafkaConsumer should validate topics/TopicPartitions on subscribe/assign
Date Wed, 25 Oct 2017 18:50:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219275#comment-16219275
] 

ASF GitHub Bot commented on KAFKA-5848:
---------------------------------------

GitHub user vahidhashemian opened a pull request:

    https://github.com/apache/kafka/pull/4135

    KAFKA-5848: Perform a complete topic name validation in KafkaConsumer's assign/subscribe

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-5848

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/4135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4135
    
----
commit 572e13c2ec9e88f154574a0500c64f403bf0657e
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Date:   2017-10-05T21:44:15Z

    KAFKA-5848: Perform a complete topic name validation in KafkaConsumer's assign/subscribe

----


> KafkaConsumer should validate topics/TopicPartitions on subscribe/assign
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-5848
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5848
>             Project: Kafka
>          Issue Type: Bug
>          Components: clients
>    Affects Versions: 0.11.0.0
>            Reporter: Matthias J. Sax
>            Assignee: Vahid Hashemian
>            Priority: Minor
>
> Currently, {{KafkaConsumer}} checks if the provided topics on {{subscribe()}} and {{TopicPartition}}
on {{assign()}} don't contain topic names that are {{null}} or an empty string. 
> However, it could do some more validation:
>  - check if invalid topic characters are in the string (this might be feasible for {Patterns}},
too?)
>  - check if provided partition numbers are valid (ie, not negative and maybe not larger
than the available partitions?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message