Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 05466200D1F for ; Thu, 28 Sep 2017 23:01:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 03AD51609B4; Thu, 28 Sep 2017 21:01:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4CB691609CD for ; Thu, 28 Sep 2017 23:01:05 +0200 (CEST) Received: (qmail 65224 invoked by uid 500); 28 Sep 2017 21:01:04 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 65203 invoked by uid 99); 28 Sep 2017 21:01:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Sep 2017 21:01:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EB02FD3754 for ; Thu, 28 Sep 2017 21:01:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 8WHgaMOHUctX for ; Thu, 28 Sep 2017 21:01:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D45AA60D2C for ; Thu, 28 Sep 2017 21:01:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A94CAE0EEE for ; Thu, 28 Sep 2017 21:01:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D146C242B7 for ; Thu, 28 Sep 2017 21:01:00 +0000 (UTC) Date: Thu, 28 Sep 2017 21:01:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-5949) User Callback Exceptions need to be handled properly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 28 Sep 2017 21:01:06 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184864#comment-16184864 ] ASF GitHub Bot commented on KAFKA-5949: --------------------------------------- GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/3986 KAFKA-5949: Follow-up after latest KIP-161 changes - compare KAFKA-5958 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka kafka-5949-exceptions-user-callbacks-KIP-161-follow-up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3986.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3986 ---- commit 95ebc1ef168b35fe3c7e1e23201114fbafee12bb Author: Matthias J. Sax Date: 2017-09-28T20:58:45Z KAFKA-5949: Follow-up after latest KIP-161 changes - compare KAFKA-5958 ---- > User Callback Exceptions need to be handled properly > ---------------------------------------------------- > > Key: KAFKA-5949 > URL: https://issues.apache.org/jira/browse/KAFKA-5949 > Project: Kafka > Issue Type: Sub-task > Components: streams > Reporter: Matthias J. Sax > Assignee: Matthias J. Sax > Fix For: 1.0.0 > > > In Streams, we allow to register multiple user callbacks. We need to handle those exceptions gracefully, by catching and wrapping with a StreamsException. > - TimestampExtractor > - DeserializationHandler > - StateRestoreListener -- This message was sent by Atlassian JIRA (v6.4.14#64029)