Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@kafka.apache.org
Date: Fri, 29 Sep 2017 20:19:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: jira@kafka.apache.org
Message-ID: <JIRA.13095276.1502961306000.239296.1506716340236@Atlassian.JIRA>
In-Reply-To: <JIRA.13095276.1502961306000@Atlassian.JIRA>
References: <JIRA.13095276.1502961306000@Atlassian.JIRA> <JIRA.13095276.1502961306718@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-5746) Add new metrics to support health
 checks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 29 Sep 2017 20:19:05 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186333#comment-16186333 ] 

ASF GitHub Bot commented on KAFKA-5746:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/3996

    KAFKA-5746; Return 0.0 from Metric.value() instead of throwing exception

    This is less likely to break custom metric reporters and since the method
    is deprecated, people will be warned about this potential issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka avoid-exception-in-measurable-value

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3996
    
----
commit e97844d036dfe1bc2e795ddb12b5c61201ab3c9c
Author: Ismael Juma <ismael@juma.me.uk>
Date:   2017-09-29T20:14:57Z

    KAFKA-5746; Return 0.0 from Metric.value() instead of throwing exception
    
    This is less likely to break custom metric reporters and since the method
    is deprecated, people will be warned about this potential issue.

----


> Add new metrics to support health checks
> ----------------------------------------
>
>                 Key: KAFKA-5746
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5746
>             Project: Kafka
>          Issue Type: New Feature
>          Components: metrics
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>             Fix For: 1.0.0
>
>
> It will be useful to have some additional metrics to support health checks.
> Details are in [KIP-188|https://cwiki.apache.org/confluence/display/KAFKA/KIP-188+-+Add+new+metrics+to+support+health+checks]


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)