Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@kafka.apache.org
Date: Thu, 7 Sep 2017 14:35:00 +0000 (UTC)
From: "Paolo Patierno (JIRA)" <jira@apache.org>
To: jira@kafka.apache.org
Message-ID: <JIRA.13093726.1502358586000.50070.1504794900398@Atlassian.JIRA>
In-Reply-To: <JIRA.13093726.1502358586000@Atlassian.JIRA>
References: <JIRA.13093726.1502358586000@Atlassian.JIRA> <JIRA.13093726.1502358586802@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (KAFKA-5723) Refactor
 BrokerApiVersionsCommand to use AdminClient
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 07 Sep 2017 14:35:15 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157009#comment-16157009 ] 

Paolo Patierno edited comment on KAFKA-5723 at 9/7/17 2:34 PM:
---------------------------------------------------------------

[~adyachkov] [~viktorsomogyi] the discussion on how to handle this is going on the mailing list. What [~ijuma] is proposing is to have small PRs against the trunk so that the committers can check and merge them easily.
My idea is the following :

* Then [KAFKA-3268|https://issues.apache.org/jira/browse/KAFKA-3268] can be used as umbrella for our works on different components
* For sure we have some common components (i.e. CommandOptions). My idea is to get my CommandOptions class and the suggestion from [~adyachkov] (from his PR) and then making a PR with just it and some other changes. This should be done adding a subtask to main KAFKA-3268 JIRA.
* Then you and committers can review the PR
* When the PR will be merged we can continue on our different works refactoring the different tools

Does it make sense to you ?


was (Author: ppatierno):
[~adyachkov] [~viktorsomogyi] the discussion on how to handle this is going on the mailing list. What [~ijuma] is proposing is to have small PRs against the trunk so that the committers can check and merge them easily.
My idea is the following :

* Then [KAFKA-3268|https://issues.apache.org/jira/browse/KAFKA-3268] can be used as umbrella for our works on different components
* For sure we have some common components (i.e. CommandOptions). My idea is to get my CommandOptions class and the suggestion from [~adyachkov] (from his PR) and then making a PR with just it and some other changes. This should be don adding a subtask to main KAFKA-3268 JIRA.
* Then you and committers can review the PR
* When the PR will be merged we can continue on our different works refactoring the different tools

Does it make sense to you ?

> Refactor BrokerApiVersionsCommand to use AdminClient
> ----------------------------------------------------
>
>                 Key: KAFKA-5723
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5723
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Viktor Somogyi
>            Assignee: Viktor Somogyi
>
> Currently it uses the deprecated AdminClient and in order to remove usages of that client, this class needs to be refactored.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)