Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 03B6B200CF6 for ; Mon, 18 Sep 2017 13:14:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 021B61609DB; Mon, 18 Sep 2017 11:14:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 48C571609D8 for ; Mon, 18 Sep 2017 13:14:07 +0200 (CEST) Received: (qmail 81482 invoked by uid 500); 18 Sep 2017 11:14:06 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 81471 invoked by uid 99); 18 Sep 2017 11:14:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Sep 2017 11:14:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BAD58180900 for ; Mon, 18 Sep 2017 11:14:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 9xp1x_4zbJQR for ; Mon, 18 Sep 2017 11:14:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8C17C5F3CF for ; Mon, 18 Sep 2017 11:14:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03636E0295 for ; Mon, 18 Sep 2017 11:14:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CB11425381 for ; Mon, 18 Sep 2017 11:14:01 +0000 (UTC) Date: Mon, 18 Sep 2017 11:14:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-5515) Consider removing date formatting from Segments class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 18 Sep 2017 11:14:08 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169888#comment-16169888 ] ASF GitHub Bot commented on KAFKA-5515: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3783 > Consider removing date formatting from Segments class > ----------------------------------------------------- > > Key: KAFKA-5515 > URL: https://issues.apache.org/jira/browse/KAFKA-5515 > Project: Kafka > Issue Type: Improvement > Components: streams > Reporter: Bill Bejeck > Assignee: Damian Guy > Labels: performance > Fix For: 1.0.0 > > > Currently the {{Segments}} class uses a date when calculating the segment id and uses {{SimpleDateFormat}} for formatting the segment id. However this is a high volume code path and creating a new {{SimpleDateFormat}} and formatting each segment id is expensive. We should look into removing the date from the segment id or at a minimum use a faster alternative to {{SimpleDateFormat}}. We should also consider keeping a lookup of existing segments to avoid as many string operations as possible. -- This message was sent by Atlassian JIRA (v6.4.14#64029)