kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "huxihx (JIRA)" <j...@apache.org>
Subject [jira] [Created] (KAFKA-5976) RequestChannel.sendReponse records incorrect size for NetworkSend with TRACE logging
Date Tue, 26 Sep 2017 09:08:00 GMT
huxihx created KAFKA-5976:
-----------------------------

             Summary: RequestChannel.sendReponse records incorrect size for NetworkSend with
TRACE logging
                 Key: KAFKA-5976
                 URL: https://issues.apache.org/jira/browse/KAFKA-5976
             Project: Kafka
          Issue Type: Bug
          Components: core
    Affects Versions: 0.11.0.1
            Reporter: huxihx
            Assignee: huxihx


In RequestChannel.scala, RequestChannel.sendResponse records incorrect size for `NetworkSend`
when trace logging is enabled, as shown below:

{code:title=RequestChannel.scala|borderStyle=solid}
def sendResponse(response: RequestChannel.Response) {
    if (isTraceEnabled) {
      val requestHeader = response.request.header
      trace(s"Sending ${requestHeader.apiKey} response to client ${requestHeader.clientId}
of " + s"${response.responseSend.size} bytes.")
    }
{code}

`responseSend` is of `scala.Option` type so it should be `response.responseSend.get.size`.


No need to check if they are none here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message