kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5968) Remove all broker metrics during shutdown
Date Fri, 29 Sep 2017 11:10:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185693#comment-16185693

ASF GitHub Bot commented on KAFKA-5968:

GitHub user rajinisivaram opened a pull request:


    KAFKA-5968: Create/remove request metrics during broker startup/shutdown

    Replaces the static `RequestMetrics` object with a class so that metrics are created and
removed during broker startup and shutdown to avoid metrics tests being affected by metrics
left behind by previous tests. Also reinstates `kafka.api.MetricsTest` which was failing frequently
earlier due to tests removing the static request metrics.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-5968

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3991
commit ee50940631bc387223045a21a1ded689e15852fb
Author: Rajini Sivaram <rajinisivaram@googlemail.com>
Date:   2017-09-29T10:27:22Z

    KAFKA-5968: Create/remove request metrics during broker startup/shutdown


> Remove all broker metrics during shutdown
> -----------------------------------------
>                 Key: KAFKA-5968
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5968
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>             Fix For: 1.1.0
>         Attachments: 5968.v1.txt
> RequestMetrics on the broker is currently a static variable, created when the broker
starts up, but the metrics are never removed. This makes it hard to test broker metrics since
there could be metrics left over from previous tests. We should ensure that all metrics are
cleared even for brokers.

This message was sent by Atlassian JIRA

View raw message